Add mm, mm/min and g/min units for directed energy deposition #128
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ICoN-PCL LP-DED registration needs millimetres (hatch spacing, layer thickness), mm/min (scan speed) and g/min (powder feed). The registration dropdown now offers them, and the FAIR export maps mm/min and g/min to QUDT MilliM-PER-MIN and GM-PER-MIN (previously no QUDT unit). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The ICoN-PCL team (Dina Khattab, Xavier Portalatin) is registering an LP-DED. Their inputs use mm (hatch spacing, layer thickness), mm/min (scan speed) and g/min (powder feed), which the registration dropdown doesn't offer. The backend already accepts any unit text, so only the web list and the FAIR export were missing them.
What changes
web/app/equipment/register/page.tsx: the unit dropdown adds mm, mm/min and g/min. It's used for both inputs and outputs.api/fair_ontology.py: the FAIR export mapsmm/min→ QUDTMilliM-PER-MIN(LinearVelocity) andg/min→GM-PER-MIN(MassFlowRate). Before this change both exported with no QUDT unit;mmwas already mapped. Both URIs were checked on qudt.org (200; a known-missing unit returns 404). The aliases stay case-sensitive, soG/minorMM/mindon't match.Tests
test_directed_energy_deposition_units: the fair ontology tests pass (27).test_rcac_gateway, also fails ondevwithout this change.Deploy
Web and API images; no migration. Equipment definitions are unaffected, so no version bump.
🤖 Generated with Claude Code